shiyue/aicommits
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: improve commit length enforcement (#206)

Browse Source
This commit is contained in:
hiroki osame
2023-05-03 08:53:05 -04:00
committed by GitHub
parent f53fb85dd7
commit f466f0527e
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/utils/openai.ts
View File

@@ -109,10 +109,10 @@ const getPrompt = (
diff: string, diff: string,
maxLength: number, maxLength: number,
) => `${[ ) => `${[
'Generate a concise git commit message written in present tense for the following code diff with the given specifications.', 'Generate a concise git commit message written in present tense for the following code diff with the given specifications below:',
`Message language: ${locale}`, `Message language: ${locale}`,
`Max message character length: ${maxLength}`, `Commit message must be a maximum of ${maxLength} characters.`,
'Exclude anything unnecessary such as the original translation—your entire response will be passed directly into git commit.', 'Exclude anything unnecessary such as translation. Your entire response will be passed directly into git commit.',
].join('\n')}\n\n${diff}`; ].join('\n')}\n\n${diff}`;
const generateStringFromLength = (length: number) => { const generateStringFromLength = (length: number) => {

12
tests/specs/cli/commits.ts
View File

@@ -55,7 +55,7 @@ export default testSuite(({ describe }) => {
commitMessage, commitMessage,
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });
@@ -122,7 +122,7 @@ export default testSuite(({ describe }) => {
commitMessage, commitMessage,
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });
@@ -165,7 +165,7 @@ export default testSuite(({ describe }) => {
commitMessage, commitMessage,
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });
@@ -203,7 +203,7 @@ export default testSuite(({ describe }) => {
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage).toMatch(japanesePattern); expect(commitMessage).toMatch(japanesePattern);
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });
@@ -267,7 +267,7 @@ export default testSuite(({ describe }) => {
commitMessage, commitMessage,
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });
@@ -302,7 +302,7 @@ export default testSuite(({ describe }) => {
commitMessage, commitMessage,
length: commitMessage.length, length: commitMessage.length,
}); });
expect(commitMessage.length <= 50).toBe(true); expect(commitMessage.length).toBeLessThanOrEqual(50);
await fixture.rm(); await fixture.rm();
}); });