feat: display formatted email if member has not set display name

This commit is contained in:
Henry
2025-01-31 16:47:45 +00:00
parent 7db21596f1
commit e421b4326c
7 changed files with 108 additions and 43 deletions

View File

@@ -0,0 +1,12 @@
const LabelIcon = ({ colourCode }: { colourCode: string | null }) => (
<svg
fill={colourCode ?? "#3730a3"}
className="h-2 w-2"
viewBox="0 0 6 6"
aria-hidden="true"
>
<circle cx={3} cy={3} r={3} />
</svg>
);
export default LabelIcon;

View File

@@ -28,3 +28,17 @@ export const getInitialsFromName = (name: string) => {
.map((namePart) => namePart.charAt(0).toUpperCase()) .map((namePart) => namePart.charAt(0).toUpperCase())
.join(""); .join("");
}; };
export const formatMemberDisplayName = (
name: string | null,
email: string | null,
) => {
if (name) return name;
if (!email) return "";
const localPart = email.split("@")[0];
if (!localPart) return "";
return localPart.replace(/[_-]/g, ".");
};

View File

@@ -9,7 +9,8 @@ import { IoFilterOutline } from "react-icons/io5";
import Avatar from "~/components/Avatar"; import Avatar from "~/components/Avatar";
import Button from "~/components/Button"; import Button from "~/components/Button";
import CheckboxDropdown from "~/components/CheckboxDropdown"; import CheckboxDropdown from "~/components/CheckboxDropdown";
import { formatToArray } from "~/utils/helpers"; import LabelIcon from "~/components/LabelIcon";
import { formatMemberDisplayName, formatToArray } from "~/utils/helpers";
import { getPublicUrl } from "~/utils/supabase/getPublicUrl"; import { getPublicUrl } from "~/utils/supabase/getPublicUrl";
interface BoardData { interface BoardData {
@@ -58,17 +59,6 @@ interface BoardData {
}[]; }[];
} }
const LabelIcon = ({ colourCode }: { colourCode: string | null }) => (
<svg
fill={colourCode ?? "#3730a3"}
className="h-2 w-2"
viewBox="0 0 6 6"
aria-hidden="true"
>
<circle cx={3} cy={3} r={3} />
</svg>
);
const Filters = ({ const Filters = ({
position = "right", position = "right",
boardData, boardData,
@@ -95,7 +85,10 @@ const Filters = ({
const formattedMembers = const formattedMembers =
boardData?.workspace?.members?.map((member) => ({ boardData?.workspace?.members?.map((member) => ({
key: member.publicId, key: member.publicId,
value: member.user?.name ?? "", value: formatMemberDisplayName(
member.user?.name ?? null,
member.user?.email ?? null,
),
selected: !!router.query.members?.includes(member.publicId), selected: !!router.query.members?.includes(member.publicId),
leftIcon: ( leftIcon: (
<Avatar <Avatar

View File

@@ -8,14 +8,18 @@ import {
import type { NewCardInput } from "@kan/api/types"; import type { NewCardInput } from "@kan/api/types";
import Avatar from "~/components/Avatar";
import Button from "~/components/Button"; import Button from "~/components/Button";
import CheckboxDropdown from "~/components/CheckboxDropdown"; import CheckboxDropdown from "~/components/CheckboxDropdown";
import Input from "~/components/Input"; import Input from "~/components/Input";
import LabelIcon from "~/components/LabelIcon";
import Toggle from "~/components/Toggle"; import Toggle from "~/components/Toggle";
import { useBoard } from "~/providers/board"; import { useBoard } from "~/providers/board";
import { useModal } from "~/providers/modal"; import { useModal } from "~/providers/modal";
import { usePopup } from "~/providers/popup"; import { usePopup } from "~/providers/popup";
import { api } from "~/utils/api"; import { api } from "~/utils/api";
import { formatMemberDisplayName } from "~/utils/helpers";
import { getPublicUrl } from "~/utils/supabase/getPublicUrl";
type NewCardFormInput = NewCardInput & { type NewCardFormInput = NewCardInput & {
isCreateAnotherEnabled: boolean; isCreateAnotherEnabled: boolean;
@@ -73,7 +77,7 @@ export function NewCardForm({ listPublicId }: NewCardFormProps) {
boardData?.labels.map((label) => ({ boardData?.labels.map((label) => ({
key: label.publicId, key: label.publicId,
value: label.name, value: label.name,
selected: labelPublicIds.includes(label.publicId), leftIcon: <LabelIcon colourCode={label.colourCode} />,
})) ?? []; })) ?? [];
const formattedLists = const formattedLists =
@@ -86,8 +90,20 @@ export function NewCardForm({ listPublicId }: NewCardFormProps) {
const formattedMembers = const formattedMembers =
boardData?.workspace?.members.map((member) => ({ boardData?.workspace?.members.map((member) => ({
key: member.publicId, key: member.publicId,
value: member.user?.name ?? "", value: formatMemberDisplayName(
selected: memberPublicIds.includes(member.publicId), member.user?.name ?? null,
member.user?.email ?? null,
),
leftIcon: (
<Avatar
size="xs"
name={member.user?.name ?? ""}
imageUrl={
member.user?.image ? getPublicUrl(member.user.image) : undefined
}
email={member.user?.email ?? ""}
/>
),
})) ?? []; })) ?? [];
const onSubmit = (data: NewCardInput) => { const onSubmit = (data: NewCardInput) => {

View File

@@ -1,12 +1,11 @@
import { Fragment } from "react";
import { api } from "~/utils/api";
import { Menu, Transition } from "@headlessui/react"; import { Menu, Transition } from "@headlessui/react";
import { HiMiniPlus } from "react-icons/hi2"; import { Fragment } from "react";
import { useForm } from "react-hook-form"; import { useForm } from "react-hook-form";
import { HiEllipsisHorizontal, HiMiniPlus } from "react-icons/hi2";
import LabelIcon from "~/components/LabelIcon";
import { useModal } from "~/providers/modal"; import { useModal } from "~/providers/modal";
import { api } from "~/utils/api";
import { HiEllipsisHorizontal } from "react-icons/hi2";
interface LabelSelectorProps { interface LabelSelectorProps {
cardPublicId: string; cardPublicId: string;
@@ -37,7 +36,7 @@ export default function LabelSelector({
const { register, handleSubmit, setValue, watch } = useForm({ const { register, handleSubmit, setValue, watch } = useForm({
values: Object.fromEntries( values: Object.fromEntries(
labels?.map((label) => [label.publicId, label.selected]) ?? [], labels.map((label) => [label.publicId, label.selected]) ?? [],
), ),
}); });
@@ -100,7 +99,7 @@ export default function LabelSelector({
<Menu.Items className="absolute right-[200px] top-[30px] z-10 mt-2 w-56 origin-top-right rounded-md border-[1px] border-light-600 bg-light-50 shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none dark:border-dark-500 dark:bg-dark-200"> <Menu.Items className="absolute right-[200px] top-[30px] z-10 mt-2 w-56 origin-top-right rounded-md border-[1px] border-light-600 bg-light-50 shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none dark:border-dark-500 dark:bg-dark-200">
<div className="p-2"> <div className="p-2">
<form onSubmit={handleSubmit(onSubmit)}> <form onSubmit={handleSubmit(onSubmit)}>
{labels?.map((label) => ( {labels.map((label) => (
<Menu.Item key={label.publicId}> <Menu.Item key={label.publicId}>
{() => ( {() => (
<div <div
@@ -127,12 +126,18 @@ export default function LabelSelector({
checked={watch(label.publicId)} checked={watch(label.publicId)}
/> />
<div className="flex w-full items-center justify-between"> <div className="flex w-full items-center justify-between">
<label <div className="flex items-center">
htmlFor={label.publicId} <span className="ml-3 flex items-center">
className="ml-3 text-sm" <LabelIcon colourCode={label.colourCode} />
> </span>
{label.name} <label
</label> htmlFor={label.publicId}
className="ml-3 text-sm"
>
{label.name}
</label>
</div>
<button <button
className="invisible group-hover:visible" className="invisible group-hover:visible"
onClick={(event) => { onClick={(event) => {

View File

@@ -1,8 +1,12 @@
import { Fragment } from "react";
import { api } from "~/utils/api";
import { Menu, Transition } from "@headlessui/react"; import { Menu, Transition } from "@headlessui/react";
import { HiMiniPlus } from "react-icons/hi2"; import { Fragment } from "react";
import { useForm } from "react-hook-form"; import { useForm } from "react-hook-form";
import { HiMiniPlus } from "react-icons/hi2";
import Avatar from "~/components/Avatar";
import { api } from "~/utils/api";
import { formatMemberDisplayName } from "~/utils/helpers";
import { getPublicUrl } from "~/utils/supabase/getPublicUrl";
interface MemberSelectorProps { interface MemberSelectorProps {
cardPublicId: string; cardPublicId: string;
@@ -11,6 +15,8 @@ interface MemberSelectorProps {
user: { user: {
id: string; id: string;
name: string | null; name: string | null;
image: string | null;
email: string | null;
}; };
selected: boolean; selected: boolean;
}[]; }[];
@@ -34,7 +40,7 @@ export default function MemberSelector({
const { register, handleSubmit, setValue, watch } = useForm({ const { register, handleSubmit, setValue, watch } = useForm({
values: Object.fromEntries( values: Object.fromEntries(
members?.map((member) => [member.publicId, member.selected]) ?? [], members.map((member) => [member.publicId, member.selected]) ?? [],
), ),
}); });
@@ -64,8 +70,8 @@ export default function MemberSelector({
className="relative z-30 inline-flex h-6 w-6 items-center justify-center rounded-full bg-gray-500 ring-1 ring-light-200 dark:ring-dark-100" className="relative z-30 inline-flex h-6 w-6 items-center justify-center rounded-full bg-gray-500 ring-1 ring-light-200 dark:ring-dark-100"
> >
<span className="text-[10px] font-medium leading-none text-white"> <span className="text-[10px] font-medium leading-none text-white">
{member.user?.name {member.user.name
? member.user?.name ? member.user.name
.split(" ") .split(" ")
.map((namePart) => namePart.charAt(0).toUpperCase()) .map((namePart) => namePart.charAt(0).toUpperCase())
.join("") .join("")
@@ -94,7 +100,7 @@ export default function MemberSelector({
<Menu.Items className="absolute right-[200px] top-[30px] z-10 mt-2 w-56 origin-top-right rounded-md border-[1px] border-light-600 bg-light-50 shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none dark:border-dark-500 dark:bg-dark-200"> <Menu.Items className="absolute right-[200px] top-[30px] z-10 mt-2 w-56 origin-top-right rounded-md border-[1px] border-light-600 bg-light-50 shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none dark:border-dark-500 dark:bg-dark-200">
<div className="p-2"> <div className="p-2">
<form onSubmit={handleSubmit(onSubmit)}> <form onSubmit={handleSubmit(onSubmit)}>
{members?.map((member) => ( {members.map((member) => (
<Menu.Item key={member.publicId}> <Menu.Item key={member.publicId}>
{() => ( {() => (
<div <div
@@ -120,12 +126,29 @@ export default function MemberSelector({
{...register(member.publicId)} {...register(member.publicId)}
checked={watch(member.publicId)} checked={watch(member.publicId)}
/> />
<label <div className="flex items-center">
htmlFor={member.publicId} <span className="ml-3 flex items-center">
className="ml-3 text-sm" <Avatar
> size="xs"
{member?.user?.name} name={member.user.name ?? ""}
</label> imageUrl={
member.user.image
? getPublicUrl(member.user.image)
: undefined
}
email={member.user.email ?? ""}
/>
</span>
<label
htmlFor={member.publicId}
className="ml-3 text-sm"
>
{formatMemberDisplayName(
member.user.name,
member.user.email,
)}
</label>
</div>
</div> </div>
)} )}
</Menu.Item> </Menu.Item>

View File

@@ -237,7 +237,9 @@ export const getWithListAndMembersByPublicId = async (
publicId, publicId,
user!workspace_members_userId_user_id_fk ( user!workspace_members_userId_user_id_fk (
id, id,
name name,
email,
image
) )
) )
) )