fix: reliably select workspace on login

apps/web/src/providers/workspace.tsx

@@ -103,19 +103,24 @@ export const WorkspaceProvider: React.FC<{ children: ReactNode }> = ({
     }
 
     if (storedWorkspaceId !== null) {
-      const newData = data;
+      const selectedWorkspace = data.find(
-      const selectedWorkspace = newData.find(
         ({ workspace }) => workspace.publicId === storedWorkspaceId,
       );
 
       if (!selectedWorkspace?.workspace) {
+        if (pendingWorkspaceId) {
           pollAttemptsRef.current += 1;
           if (pollAttemptsRef.current >= MAX_POLL_ATTEMPTS) {
             setPendingWorkspaceId(null);
-        }
+            localStorage.removeItem("workspacePublicId");
+          } else {
             return;
           }
-
+        } else {
+          // Clear stale workspacePublicId from localStorage
+          localStorage.removeItem("workspacePublicId");
+        }
+      } else {
         pollAttemptsRef.current = 0;
         setPendingWorkspaceId(null);
 
@@ -125,7 +130,7 @@ export const WorkspaceProvider: React.FC<{ children: ReactNode }> = ({
           slug: selectedWorkspace.workspace.slug,
           plan: selectedWorkspace.workspace.plan,
           description: selectedWorkspace.workspace.description,
-        role: selectedWorkspace.role,
+          role: selectedWorkspace.role as "admin" | "member" | "guest",
           weekStartDay: selectedWorkspace.workspace.weekStartDay as 0 | 1 | 6,
           cardPrefix: selectedWorkspace.workspace.cardPrefix,
         });
@@ -134,7 +139,12 @@ export const WorkspaceProvider: React.FC<{ children: ReactNode }> = ({
           router.push(`/boards`);
           localStorage.setItem("workspacePublicId", workspacePublicId);
         }
-    } else {
+
+        setHasLoaded(true);
+        return;
+      }
+    }
+
     const primaryWorkspace = data[0]?.workspace;
     const primaryWorkspaceRole = data[0]?.role;
 
@@ -146,12 +156,19 @@ export const WorkspaceProvider: React.FC<{ children: ReactNode }> = ({
       slug: primaryWorkspace.slug,
       plan: primaryWorkspace.plan,
       description: primaryWorkspace.description,
-        role: primaryWorkspaceRole,
+      role: primaryWorkspaceRole as "admin" | "member" | "guest",
       weekStartDay: primaryWorkspace.weekStartDay as 0 | 1 | 6,
       cardPrefix: primaryWorkspace.cardPrefix,
     });
-    }
+    setHasLoaded(true);
-  }, [data, isLoading, isFetching, workspacePublicId, router]);
+  }, [
+    data,
+    isLoading,
+    isFetching,
+    workspacePublicId,
+    pendingWorkspaceId,
+    router,
+  ]);
 
   return (
     <WorkspaceContext.Provider