fix: list dnd when board exceeds viewport width

packages/api/src/routers/card.ts

@@ -8,24 +8,20 @@ import * as checklistRepo from "@kan/db/repository/checklist.repo";
 import * as labelRepo from "@kan/db/repository/label.repo";
 import * as listRepo from "@kan/db/repository/list.repo";
 import * as workspaceRepo from "@kan/db/repository/workspace.repo";
-import { generateAttachmentUrl, generateAvatarUrl } from "@kan/shared/utils";
 
-import {
-  activityItemSchema,
-  cardCreateResponseSchema,
-  cardDetailSchema,
-  cardUpdateResponseSchema,
-  commentDeleteResponseSchema,
-  commentResponseSchema,
-} from "../schemas";
 import { createTRPCRouter, protectedProcedure, publicProcedure } from "../trpc";
+import {
+  cardCreateResponseSchema,
+  cardUpdateResponseSchema,
+  cardDetailSchema,
+  commentResponseSchema,
+  commentDeleteResponseSchema,
+  activityItemSchema,
+} from "../schemas";
 import { mergeActivities } from "../utils/activities";
 import { sendMentionEmails } from "../utils/notifications";
-import {
+import { assertCanDelete, assertCanEdit, assertPermission } from "../utils/permissions";
-  assertCanDelete,
+import { generateAttachmentUrl, generateAvatarUrl } from "@kan/shared/utils";
-  assertCanEdit,
-  assertPermission,
-} from "../utils/permissions";
 import {
   createCardWebhookPayload,
   sendWebhooksForWorkspace,
@@ -250,12 +246,7 @@ export const cardRouter = createTRPCRouter({
           code: "NOT_FOUND",
         });
 
-      await assertPermission(
+      await assertPermission(ctx.db, userId, card.workspaceId, "comment:create");
-        ctx.db,
-        userId,
-        card.workspaceId,
-        "comment:create",
-      );
 
       const newComment = await cardCommentRepo.create(ctx.db, {
         comment: input.comment,
@@ -333,7 +324,7 @@ export const cardRouter = createTRPCRouter({
         input.commentPublicId,
       );
 
-      if (!existingComment || existingComment.cardId !== card.id)
+      if (!existingComment)
         throw new TRPCError({
           message: `Comment with public ID ${input.commentPublicId} not found`,
           code: "NOT_FOUND",
@@ -421,7 +412,7 @@ export const cardRouter = createTRPCRouter({
         input.commentPublicId,
       );
 
-      if (!existingComment || existingComment.cardId !== card.id)
+      if (!existingComment)
         throw new TRPCError({
           message: `Comment with public ID ${input.commentPublicId} not found`,
           code: "NOT_FOUND",
@@ -910,7 +901,10 @@ export const cardRouter = createTRPCRouter({
         | undefined;
 
       if (input.listPublicId) {
-        newList = await listRepo.getByPublicId(ctx.db, input.listPublicId);
+        newList = await listRepo.getByPublicId(
+          ctx.db,
+          input.listPublicId,
+        );
 
         if (!newList)
           throw new TRPCError({
@@ -1054,14 +1048,12 @@ export const cardRouter = createTRPCRouter({
       ) {
         webhookChanges.dueDate = { from: previousDueDate, to: input.dueDate };
       }
-      const movedToNewList = Boolean(
+      const movedToNewList = Boolean(newListId && existingCard.listId !== newListId);
-        newListId && existingCard.listId !== newListId,
-      );
       const currentWebhookListPublicId = movedToNewList
         ? input.listPublicId!
         : existingCard.list.publicId;
       const currentWebhookListName = movedToNewList
-        ? (newList?.name ?? card.listName)
+        ? newList?.name ?? card.listName
         : existingCard.list.name;
 
       if (movedToNewList) {
@@ -1299,10 +1291,7 @@ export const cardRouter = createTRPCRouter({
 
       if (input.copyLabels && sourceCard.labels?.length) {
         const labelPublicIds = sourceCard.labels.map((l) => l.publicId);
-        const labels = await labelRepo.getAllByPublicIds(
+        const labels = await labelRepo.getAllByPublicIds(ctx.db, labelPublicIds);
-          ctx.db,
-          labelPublicIds,
-        );
         if (labels.length) {
           const labelsInsert = labels.map((label) => ({
             cardId: newCard.id,

packages/db/src/repository/cardComment.repo.ts

@@ -45,7 +45,6 @@ export const getByPublicId = (db: dbClient, publicId: string) => {
       publicId: true,
       comment: true,
       createdBy: true,
-      cardId: true,
     },
     where: eq(comments.publicId, publicId),
   });